[Ginp-developers] Latest changes
Brought to you by:
burchbri,
dougculnane
From: Brian B. <br...@Pi...> - 2007-01-08 16:44:01
|
Doug, You will see I've made quite a few changes (commit little and often) to improve the quality of the existing unit tests, but I'm slightly puzzled that I cannot find them on http://ginp.sourceforge.net/statscm/2007-01.html do you know why? You will see I've mainly been working on logging during unit tests... I don't have an ideal solution at the moment because it is not possible to programatically change the Commons Logging level /after/ the first Log instance has been created by the LoggerFactoryImpl. This is a combination of limitations in the way LoggerFactoryImpl processes the sources of its Properties and a lack of flexibility in SimpleLogger. If I had more time and enthusiasm, I would start with some code I have in another (private) project and do it properly. Perhaps later this year? I also had to convert the Picture class to use Commons Logging - it was still explicitly using log4j. Once done, I discovered 4 test cases were failing because they could not find a jpeg file to play with. I sorted all that out. I wonder whether there are more classes still unconverted Commons Logging? Anyway, the project builds and tests satisfactorily. I've deployed it to my own server and it looks OK. Can you try it out too? Brian |