Re: [Ginp-developers] jUnit test logging errors

[Brian B. <br...@Pi...>]

Doug Culnane wrote:
> 
> The log4j is not really a failure it is good behavior.  You do not need
> to supply a log4j configuration file it is optional.  Maybe some users
> have their own logging set up for the web app and do not what log4j
> configured.  I use commons logging so this will be compatible with most
> other logging frameworks.

I looked into the commons logging documentation and decided to replace 
the default LoggerFactory discovery process. I have committed two new 
properties files to associate SimpleLog with our jUnit tests and 
suppress messages less severe than "error". This looks good to me, 
because it makes no assumptions about the deployment logging framework. 
Also, no misleading messages are generated during the test goal of the 
maven life-cycle.

> However most users will want log4j so they need to set the environment
> variable or drop a log4j.properties file in the class path.
> 
> Maybe this needs better explanation rather than a fix.  See the logging
> section of http://ginp.sourceforge.net/manual.html

I haven't finished with logging yet, but I need to read your manual and 
think a bit more.

BTW... I've found a couple of org.dom4j.io.SAXReader format errors in 
TestSetup. They don't prevent the war from being built, but something is 
wrong. I wonder whether I broke these tests with my earlier changes, so 
I'll investigate them before I do anything more.

Brian