Re: [Ginp-developers] My first changes

[Doug C. <do...@cu...>]

Sounds good Brian,

The log4j is not really a failure it is good behavior.  You do not need
to supply a log4j configuration file it is optional.  Maybe some users
have their own logging set up for the web app and do not what log4j
configured.  I use commons logging so this will be compatible with most
other logging frameworks.

However most users will want log4j so they need to set the environment
variable or drop a log4j.properties file in the class path.

Maybe this needs better explanation rather than a fix.  See the logging
section of http://ginp.sourceforge.net/manual.html

All the best,

Doug


Brian Burch wrote:
> Hi, Doug. Thanks for putting me onto the developers list.
>
> I've just committed three related changes and have fixed the "is a 
> directory" exception in TestSetup.
>
> 1. I changed the already-successful TestGinpModel.setup() method to use 
> the platform-independent file path separator. This minor refactoring 
> allowed me to debug and understand the behaviour of the java.io.File 
> class, which was not intuitively obvious and isn't well explained in 
> ether the jdk5 javadoc, or my older java books. I added a couple of 
> helpful comments. The Test class continued to run OK, so I committed the 
> change.
>
> 2. I then debugged and refactored SetupManagerImpl and Configuration to 
> implement the same logic. It tested successfully a) with /tmp/TestSetup/ 
> missing, b) with /tmp/TestSetup/ present but ginp.xml missing, and c) 
> with /tmp/TestSetup/ginp.xml already present. (We probably need 3 tests 
> for these different cases, but I don't think it is important enough to 
> do now - especially as I tested the cases manually and all 3 cases turn 
> up randomly when running the tests).
>
> 3. I then changed the test configuration file path constants in both 
> test classes to be os-independent.
>
> Maven now builds the war, but before I deploy it I'm going to try fixing 
> the log4j failures in the unit tests.
>
> Regards,
>
> Brian
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>