[Ginp-developers] Feedback on your changes.

[Doug C. <do...@cu...>]

Dear Justin,

I have had a better look at your work and I think it is very good 
although I do not understand much of it yet.  I did a CVSStats report 
(off line) and you now have contributed over 30% of the code to the 
project so thank you very much.

As you will see I have done some cvs ci.  My changes in summery are as 
follows:

Fix the w2k4 style. (easier than I thought)
Move the net.culnane.ginp.TestGinp class to the net.sf.ginp.test package.
Added a test target to build file.  (got all the libraries there now so 
lets use them)
Update documentation files to reflect recent changes.

I had a thought about the text of path to config file directory.  Maybe 
we should do a System.getProperty() type thing so that Windows users get 
a "C:\\Program Files\Apache\Tomcat\conf" type suggestion (Linux 
"/etc/tomcat/base" or "/usr/local/tomcat/conf/" ) by default.  This will 
make the thing so easy that even I would have got it right without 
confusion.  All you have to do is click next, next.....

I am on holiday now and so I hope to find time and enthusiasm to get 
hacking.

All the best and thanks again,

Doug


-- 
Doug Culnane
do...@cu...
www.culnane.net