[ginp-users] Change Request for build.xml

[Brian B. <br...@Pi...>]

I checked out the latest from CVS and found the "test" task fails:

noClassdefFoundError: org/apache/log4j/logger

I use the Netbeans IDE, which is fairly picky about classpaths for ant 
tasks. I can see that you bundle log4j in WEB-INF/lib, so I added a new 
pathelement to the build.xml.

Here is the diff... perhaps someone can commit my change?


Index: build.xml
===================================================================
RCS file: /cvsroot/ginp/ginp/build.xml,v
retrieving revision 1.13
diff -r1.13 build.xml
133a134
 >               <pathelement 
path="${build.home}/WEB-INF/lib/log4j-1.2.9.jar" />


--------------------

p.s. One of the unit tests fails... would you like me to see why and try 
to fix it?

Testsuite: net.sf.ginp.test.TestGinp
Tests run: 11, Failures: 1, Errors: 0, Time elapsed: 2.627 sec

Testcase: test_Collection took 2.363 sec
Testcase: test_Collection_sortPictures took 0.052 sec
Testcase: test_Commands_Logon took 0.032 sec
Testcase: test_Commands_SelectCollection took 0.022 sec
Testcase: test_GinpModel_translate took 0.02 sec
Testcase: test_command_SetLanguageCode took 0.026 sec
Testcase: test_Model took 0.02 sec
Testcase: test_ModelManager took 0.016 sec
Testcase: test_Model_pageDimensions took 0.017 sec
Testcase: test_Picture took 0.035 sec
Testcase: test_Picture_setDateTime took 0.024 sec
         FAILED
expected:<...8...> but was:<...9...>
junit.framework.ComparisonFailure: expected:<...8...> but was:<...9...>
         at 
net.sf.ginp.test.TestGinp.test_Picture_setDateTime(TestGinp.java:268)
         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
         at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
         at 
org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:125)

/home/brian/SandboxSourceForge/ginp/build.xml:117: Test 
net.sf.ginp.test.TestGinp failed
         at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.actOnTestResult(JUnitTask.java:1447)
         at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:685)
         at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeOrQueue(JUnitTask.java:1413)
         at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:633)
         at 
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:275)
         at org.apache.tools.ant.Task.perform(Task.java:364)
         at org.apache.tools.ant.Target.execute(Target.java:341)
         at org.apache.tools.ant.Target.performTasks(Target.java:369)
         at org.apache.tools.ant.Project.executeTarget(Project.java:1214)
         at org.apache.tools.ant.Project.executeTargets(Project.java:1062)
         at 
org.apache.tools.ant.module.bridge.impl.BridgeImpl.run(BridgeImpl.java:234)
         at 
org.apache.tools.ant.module.run.TargetExecutor.run(TargetExecutor.java:242)
         at 
org.netbeans.core.execution.RunClassThread.run(RunClassThread.java:125)
BUILD FAILED (total time: 5 seconds)