Menu

Source-code Merge Request #8: Add possibility to load xml files from custom source (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Alexander Guz wants to merge 1 commit from /u/s9241304/gimp-print/ to master, 2023-10-11

With these changes files may be loaded from custom sources (not only filesystem) or may be genereted on the fly.
Data provider should allocate and free up memory for xml source data, gutenprint doesn't control this

Commit Date  
[66937a] (xml-data-source) by Alexander Guz Alexander Guz

add possibility to load xml files from custom data source

2023-10-03 19:27:59 Tree

Discussion

  • Solomon Peachy

    Solomon Peachy - 2023-10-11

    Is the intent here to pass XML data in on the fly?

    But regardless, I'm not sure this can be accepted in its current form -- it adds global state that affects multi-threaded use of libgutenprint. All "global" state should be encapsulated within the stp_vars_t structure instead.

     
  • Alexander Guz

    Alexander Guz - 2023-10-11

    Is the intent here to pass XML data in on the fly?

    Not only. First thoughts were about loading data from embedded resources or network services, but now I think about setup any printing parameters using xml. For example, I want to setup inks with custom head offset values. With this functionality I don't need implement additional functionality, I can modify existing xml easily with golang or c++

    But regardless, I'm not sure this can be accepted in its current form -- it adds global state that affects multi-threaded use of libgutenprint. All "global" state should be encapsulated within the stp_vars_t structure instead.

    I think there is no global state, it works like callback, like existing stpui_set_thumbnail_func/stpui_set_thumbnail_data

     

    Last edit: Alexander Guz 2023-10-11

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.