Re: [Gimp-print-devel] print.c

[Michael N. <mit...@cs...>]

"S. Miller" wrote:
> 
> Robert L Krawitz wrote:
> >
> > As it happens, the reason I want the selectable dither algorithm stuff
> > is mostly so people can experiment, although there would be a bit more
> > reason to have that in a production release.
> >
> 
> Ok, I just grabbed the latest CVS with Dave's changes, and I have some
> merge errors.  I'll try to get this back out Friday afternoon.  I'll
> leave the ifdefs the way Mitch put them in so if you want to use the gtk
> gui you'll have to change 2 lines in print.c: find where a #ifndef
> GIMP_1_0 switches between gtk_* and gimp_*.  Change those to #ifdef and
> you'll force the use of the gtk gui. More tomorrow once I get things
> working again.  This will be more or less the original gui layout.  It
> will be a while before the notebook version is out, and I will try to
> incorporate any interim changes as they occur (if I miss something I'm
> sure I'll hear about it :))

If nobody objects I'll commit some code which adds a second menu entry
so Gimp 1.1.x users can choose which ui they want.

I was also thinking about naming the 2 procedures "file_print_gtk" and
"file_print_gimp", so it installs nicely with the print plugin
which ships with CVS gimp and which of course registers as "file_print".

Currently we seem to share the same problem, as I have to rename
the 3.1.x procedure to "file_print2" and revert this change before I
commit something...

Ok, so what about:

"gimp_print_gtk"  --> "<Image>/File/Print (Gtk)"
"gimp_print_gimp" --> "<Image>/File/Print (Gimp)"
 
> Mitch, this is incomplete, so you might want to wait until Robert fills
> in the guts of the dither selection before incorporating it.  Any
> changes will be in *_color_window.c.

Ok, I will wait for Robert's commit then.

bye,
--Mitch