Re: [Gimp-print-devel] print.c

[Michael N. <mit...@cs...>]

"S. Miller" wrote:
> 
> I'm ready to commit some changes with the skeleton for selection of
> dither algorithms.  However, I ran into a slight problem with the
> changes for slection of gimp vs gtk gui code.  It appears that Mitsch
> added some switches based on whether you're compiling for gimp 1.0.x.
> The problem is that all of us are using 1.1.x and the gtk code is never
> used. I can get around this in my sandbox by changing the 2 "#ifndef
> GIMP_1_0" lines to "#ifdef GIMP_1_0", which then shifts the else to be
> true, and gtk stuff is used. But this will break the gimp code.  The
> switch needs to be done on both gimp 1.1 vs 1.0 as well as gimp vs
> standalone.  I tried to pass an argument in, but gnu make apparantly
> doesn't understand the -D flag.  I'm assuming here that we're delivering
> the gimp version with gimp and keeping the gtk version towards working
> the generalized solution.

Yep, I'm aware of the problem. As we are in a development cycle, what
about registering 2 PDB functions, one for the old and one for the
new ui. When it comes to a release we will of course have to remove
the second one :)

Gnu make doesn't take gcc's -D into account when it calculates the
dpeendencies, that's evil (TM).

bye,
--Mitch