Re: [Gimp-print-devel] print.c

[Michael N. <mit...@cs...>]

Dave Hill wrote:
> 
> Hi
> 
> The current defines in gtk*.c and gimp*.c don't work anyway, because
> the only definition of GIMP_1_0 is in print.c. To make them work
> this definition needs moving to print_gimp.h.

Eek, I've messed this up when adding the gimp_* files because I don't have
Gimp 1.0.x here, sorry.

> Also, in gtk*, the whole code should be surrounded by
> #ifdef GIMP_1_0, otherwise you will be compiling both sets for
> gimp 1.1.x.

Also true.

> The reason I note this is because I am still using gimp 1.0.4,
> I haven't "upgraded" to the development version.
> 
> I have a set of patches ready to submit for these changes,
> also to fix a couple of minor bugs:-

Please do it.

BTW, I'm about to commit stuff to gimp-print and I'm not quite sure
about the project's ChangeLog policy.

Where are the changes logged? The ChangeLog looke quite unused right
now.

bye,
--Mitch