From: S. M. <sm...@rn...> - 2000-04-13 00:17:56
|
I'm ready to commit some changes with the skeleton for selection of dither algorithms. However, I ran into a slight problem with the changes for slection of gimp vs gtk gui code. It appears that Mitsch added some switches based on whether you're compiling for gimp 1.0.x. The problem is that all of us are using 1.1.x and the gtk code is never used. I can get around this in my sandbox by changing the 2 "#ifndef GIMP_1_0" lines to "#ifdef GIMP_1_0", which then shifts the else to be true, and gtk stuff is used. But this will break the gimp code. The switch needs to be done on both gimp 1.1 vs 1.0 as well as gimp vs standalone. I tried to pass an argument in, but gnu make apparantly doesn't understand the -D flag. I'm assuming here that we're delivering the gimp version with gimp and keeping the gtk version towards working the generalized solution. I'm looking for a solution to this - I don't have a good answer. Robert, the changes I made are to print.c (adding some dither related variables) and the selection menu and callbacks in gtk_color_window.c - if you want I can just email them to you. You will need to add a function in print.c or somewhere to fill in the dither name array and then put whatever code you need in the callback to select the dither function. Steve -- ----------------------------------------- Just because I have a short attention span doesn't mean I ------------------------------------------ |