From: Solomon P. <pi...@sh...> - 2020-03-23 02:57:35
|
On Sun, Mar 22, 2020 at 10:46:38PM -0400, Robert Krawitz wrote: > 045790c384b96d6e28651e982bcea1aedd1c7da0 broke the build with gcc > (clang works): > 2020-03-23T02:02:22+0000 CC check_duplicate_printers.test.o > 2020-03-23T02:02:22+0000 check_duplicate_printers.test.c: In function ‘main’: > 2020-03-23T02:02:22+0000 check_duplicate_printers.test.c:40:3: error: implicit declaration of function ‘putenv’; did you mean ‘setenv’? [-Werror=implicit-function-declaration] > 2020-03-23T02:02:22+0000 putenv("STP_CHECK_DUPLICATE_PRINTERS=TRUE"); > 2020-03-23T02:02:22+0000 ^~~~~~ > 2020-03-23T02:02:22+0000 setenv Hmm. I test-compiled this before committed. Granted, I did so with a modern system. Upon further inspection it appears that in spite of putenv() being part of POSIX-2001, it looks like one needs to define _SVID_SOURCE with glibc older than v2.19 (early 2014). Unfortunately I don't have a test system old enough for me to make sure this fix is sufficient.. - Solomon -- Solomon Peachy pizza at shaftnet dot org High Springs, FL ^^ (email/xmpp) ^^ Quidquid latine dictum sit, altum videtur. |