Re: [Gimp-print-devel] patches to remove bashisms

[Greg T. <gd...@le...>]

Robert Krawitz <rl...@al...> writes:

> On Tue, 17 Mar 2020 19:09:00 -0400, Greg Troxel wrote:
>> There are some minor unnecessary bashisms in a few /bin/sh scripts.
>> Basically, [[ is not specified as part of POSIX sh, and while it in bash
>> has slightly different semantics than [, I am pretty sure that's not
>> relevant in these cases.
>>
>> This is really just s/[[/[/ and s/]]/]/.
>
> Not quite...

Thanks and sorry for getting that wrong -- now I realize quoting is
needed.  I have always stuck to posix in writing scripts and was unclear
on exactly how [[ behaves.

> This isn't going to be enough; per shellcheck, substitutions such as
>
> ${gutenprint_base//./_}
>
> don't work in POSIX shell.

If that's not too annoying to fix -- that looks like inline sed -- that
would be nice.

I am not trying to run these; they just showed up because of portability
checks run on all files in the tarball.

Thanks,
Greg