Re: [Gimp-print-devel] Missing dependency check in 'make distcheck-minimal'

[Robert K. <rl...@al...>]

On Thu, 23 May 2019 09:14:25 -0400, Solomon Peachy wrote:
> Here's the output out of my automated build system:
>
> $ make distcheck-minimal
> STP_TEST_PROFILE=`echo distcheck-minimal |sed -e s/distcheck-// -e 
> s/-/_/g -e s/parallel//` STP_PARALLEL=`scripts/count-cpus` 
> STP_TEST_SUITE=1 STP_TEST_DIST=1 /usr/bin/time make -k -s 
> -j`scripts/count-cpus` DISTCHECK_CONFIGURE_FLAGS=NO_PKGCONFIG_PATHS=1 distcheck
>  (cd include && make  top_distdir=../gutenprint-5.3.2-pre1 
> distdir=../gutenprint-5.3.2-pre1/include \
>      am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
>  (cd gutenprint && make  top_distdir=../../gutenprint-5.3.2-pre1 
> distdir=../../gutenprint-5.3.2-pre1/include/gutenprint \
>      am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
>  (cd gutenprintui2 && make  top_distdir=../../gutenprint-5.3.2-pre1 
> distdir=../../gutenprint-5.3.2-pre1/include/gutenprintui2 \
>      am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
> /bin/sh: line 1: --fhead: command not found
> make[7]: *** [Makefile:712: typebuiltins.h] Error 127
> make[7]: Target 'distdir-am' not remade because of errors.
> make[6]: *** [Makefile:544: distdir] Error 2
> make[5]: *** [Makefile:571: distdir-am] Error 1
> make[4]: *** [Makefile:567: distdir] Error 2
> make[3]: *** [Makefile:721: distdir-am] Error 1
> make[2]: *** [Makefile:715: distdir] Error 2
> make[2]: Target 'dist-xz' not remade because of errors.
> make[2]: Target 'dist-bzip2' not remade because of errors.
> make[1]: *** [Makefile:818: dist] Error 2
> make[1]: Target 'distcheck' not remade because of errors.
> Command exited with non-zero status 2
>
> It's relying on 'glib-mkenums' (part of the 'glib2-devel' in 
> RedHat-land) but there's no check in the bootstrap or configure script 
> for this.  Just a confusing error message.  :)

Where exactly is this happening?  That looks like you've elided
something, so I don't have the full context.

This should only be getting run during a maintainer build; the tarball
should have the file.  In that case, this should be the fix:

diff --git a/scripts/autogen.sh b/scripts/autogen.sh
index c91f1c37..bb8e89c5 100644
--- a/scripts/autogen.sh
+++ b/scripts/autogen.sh
@@ -50,6 +50,13 @@ else
   libtool_err=1
 fi
 
+if [ -z "`type -p glib-mkenums`" ] ; then
+  echo
+  echo "**Error**: You must have \`glib2-mkenums' installed to create a"
+  echo "Gutenprint distribution.  This is usually distributed in the"
+  echo "glib2-devel, glib2-dev, or similar package."
+  DIE=1
+fi
 
 if [ -n "$libtool_err" ] ; then
   echo

-- 
Robert Krawitz                                     <rl...@al...>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton