Menu

#165 EGifSpew leaks GifFileOut->SColorMap

v1.0_(example)
closed
nobody
None
1
2026-02-19
2023-07-17
Ono-Sendai
No

EGifSpew calls EGifPutScreenDesc, passing in GifFileOut->SColorMap as the GifColorMap parameter.

In EGifPutScreenDesc, a colour map object is created with GifMakeMapObject, and assigned to SColorMap. The old data pointed to by SColorMap previously is not freed.

(The whole copying of the colour map data is also redundant, copying from itself to itself)

Discussion

  • Eric S. Raymond

    Eric S. Raymond - 2024-02-18

    Fix applied, thanks.

     
  • Eric S. Raymond

    Eric S. Raymond - 2024-02-18
    • status: open --> closed
     
  • Eric S. Raymond

    Eric S. Raymond - 2024-02-18
    • status: closed --> open
     
  • Eric S. Raymond

    Eric S. Raymond - 2024-02-18

    The fix I aspplied for this turns out to be incorrect, revealing a deeper issue about the design of the library that will take some further work.

     
  • Eric S. Raymond

    Eric S. Raymond - 2026-02-19

    Improved fix pushed.

     
  • Eric S. Raymond

    Eric S. Raymond - 2026-02-19
    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB