That's solely based on the lack of sync between the two platforms and also between the linker and the dependencies list. But that fix causes FTBFS due to unresolved symbols when linking libutil.dylib: "_GifErrorString", referenced from: _PrintGifError in qprintf.o because qprintf.o is now only in libgif not libutil. If libutil is (as name suggests) utility functions and (as the Makefile behaves on all platforms) not actually install libutil publicly, should it be static-only on all platforms?
Incorrect object files in shared libutil on darwin
Makefile: fix typo in soname argument
Prio is not 1 but very low. I failed to set it correctly.
Race-Condition on Install
Fix #171 - Require ImageMagick Only for Building Giflib Website
Please reject this merge request as the issue was already addressed by Avoid having an install-time dependency on convert(1)
Please disregard and close this issue as it was already addressed by Avoid having an install-time dependency on convert(1).
Fix #171 - Require ImageMagick Only for Building Giflib Website
ImageMagick required to build giflib on non-Darwin Platforms
I ran into this as well, building with -D_FORTIFY_SOURCE=3 - it's because the snprintf calls in giftext.c that write into AsciiForm have the length set as 3 rather than 2. Here's a patch.
Add support for CMake
Tests failing on Ubuntu Noble, giftext buffer overflow
THis patch is created based on the latest version ...
Hello Eric ! Unfortunately, I still have this error even after I've applied this patch and some others. The fix for me was to free "Buffers". Please find attached the patch.
Emphasize lossnessless.
Enable gif2rgb-regress.
More build recipe simplification.
Fix minor documentation errors
Simplify the test machinery.
Robustify against overly verbose gmake.
Shortenm some long lines.
Shorten a name in order to avoid problems when we reflow.
Correct typos, shoe=rten and fix version strings.
Move Gershon Elber's copyrights from strings to SPDX headers...
More through SPDXification.
NEWS update.
Improve cleanup of doc/
Tests are now fully TAPified.
More TAPification.
Integrate and TAPify gifinto test.
More TAPification.
Add a FIXME to testing.
Begin TAPification.
Updated by force-push.
GifQuantizeBuffer function prototype mismatch
Fix applied, thanks.
Address issue #169: GifQuantizeBuffer function prototype mismatch
NEW file correction.
GifQuantizeBuffer function prototype mismatch
Merge Request updated
A initial CMakeLists.txt for portable builds
I dislike CMake, and it is overcomplicated for this build.
fix for #157 An OutofMemory-Exception or Memory Leak in gif2rgb CVE-2021-40633
Clean up memory better at end of run (CVE-2021-40633)
Make it easier to control the build with environment variables.
Observe another fix in 5.2.2 and correct the header.
respect existence of distro CFLAGS and CPPFLAGS
Preserve ENV values for CC and PREFIX in Makefile
Removed giflib-logo target
Ok, sure, thanks for your time
Can youy ship me a version of this patch updated to work on the repository heaf?
Merged by hand, thanks.
Merged by hand, thanks.
I prever to have it there in case I ever want to modify the full-sized logo, so I don't have to think about the extra step of downscaling it for web use.
b) should be removed to finish avoiding an install-time dependency on convert for https://sourceforge.net/p/giflib/feature-requests/10/ I was wrong about this. doc/giflib-logo.gif is enough to work around the problem. It still seems like the giflib-logo target is superfluous though? Your call.
Thanks very much. I think the giflib-logo.gif target is no longer needed after that? I've created https://sourceforge.net/p/giflib/code/merge-requests/13/
Thanks for the commit. I think removing the giflib-logo.gif target is also needed, so I've created https://sourceforge.net/p/giflib/code/merge-requests/13/
Removed giflib-logo target
Great, I am going to take look at the weekend.
ImageMagick dependency on Linux
I've committed the derived giflib.a to the repository. Thanks.
Cause "make clean" to remove giflib.7
Avoid having an install-time dependency on convert(1).
Correct document page install.
giflib head installs xml files instead of manpafes
Applied.
I'd like to see it and review it.
I can't accept this patch. it breaks generration of .so files. Can you ship a conditionalized verrsion that detects mingw and does the right thing withour disturbing the GCC 10 build?
Reassert logical equivalence.
cannot compile under mingw
That should have been expanded to "if and only if" and now is.
Should be fixed now.
Correccyt wrong binary translation is docs.
OK, that is a pretty funny error. I can laugh becaause I didn't do it. Am investigating.
Matthew counting_pine@users.sourceforge.net: Hi Eric. Glad to hear that you are feeling better after being ill. (I saw you posted about it, although I can't now find those posts again. I find SourceForge a bit confusing nowadays.) I noticed your fixes in d565f and 865b8. It now says 010, but I think it should be 100, which is the last three digits of 8C (10001100), and is 4 in binary. Ugh. You're right. Please reopen thisssue. If you can't, file another one. <a href="http://www.catb.org/~esr/">Eric...
Just to clarify: if "iff" was wrong there, was that because of a typo or because of a logic mistake? If colors from ColorIn2 did exist before, could they still be copied? If the file size is not bigger than specified, could it save into the file?
Hi Eric. Glad to hear that you are feeling better after being ill. (I saw you posted about it, although I can't now find those posts again. I find SourceForge a bit confusing nowadays.) I noticed your fixes in d565f and 865b8. It now says 010, but I think it should be 100, which is the last three digits of 8C (10001100), and is 4 in binary.
The GifErrorString error is still there... $ make cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o dgif_lib.o dgif_lib.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o egif_lib.o egif_lib.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o gifalloc.o gifalloc.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o gif_err.o gif_err.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include...
The GifErrorString error is still there... $ make cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o dgif_lib.o dgif_lib.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o egif_lib.o egif_lib.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o gifalloc.o gifalloc.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include -c -o gif_err.o gif_err.c cc -std=gnu99 -fPIC -Wall -Wno-format-truncation -O2 -I/pjiu/include...
I can try to refresh this against current git head if the basic idea is OK. Please note that adding symbol versioning also breaks the ABI, so this must not be done if the soname is not bumped anyway.
giflib head installs xml files instead of manpafes
ImageMagick dependency on Linux
Ready to ship 5.2.2
Ready to ship 5.2.1
Re-reflow so the resylt will be stable under clang-format...
Bloc braces for single lines everywhere, with uncrustify.
Fix up cppcheck suppressions after reflow.
1TBS reflow.
Finish up cppcheck suppressions.
Improve cppcheck line
Quiet down cppcheck.
cppcheck cleanup - more const declarations.
cppcheck cleanup - remove unneeded guard.
cpp lint - remove unneeded guard.
Question on DGifSlurp API
Thatr depends omnn tghe last error condition reported in the Error membor of the GifType structure. Usually that will tell you what went wrong. Sorry about the long-delated reply. I don'yt check support requesrs often (most of my projects are on GitLab) and I was sidelined with serious medical issues for abour two years.
I think that patch already exists as https://sourceforge.net/p/giflib/code/merge-requests/8/ tho it may be out of date after the flurry of recent commits.
Fix various trivial cppcheck issues.