Menu

#1 Make remount robust against unknown mount options

open
nobody
None
5
2012-10-11
2011-12-25
No

After having rooted my Android phone I tried to use Ghost Commander in root mode.
Everything except the "Remount /system" function worked well.

"Remount /system" only showed an error dialog saying "invalid argument" and the used mount command.
Since the mount commandline was included it was easy to track this down to the "relatime" option which
was listed under /proc/mounts but is rejected from the mount command when given manually.

I do not know why all current mount options are repeated in the remount, but this should
not be necessary. A remount only changed the given options.

The attached patch only takes "remount" and "ro" or "rw" as options to the mount command.

Thanks a lot for Ghost Commander!

Discussion

  • Stefan Fleiter

    Stefan Fleiter - 2011-12-25

    Make remount robust against unknown mount options

     
  • zc2

    zc2 - 2011-12-25

    Thank you!

     

Log in to post a comment.