Menu

#28 xmlwriter.c: 2 * bad if test ?

v1.0_(example)
open
nobody
None
5
2013-12-19
2013-12-19
dcb
No

I just ran the static analysis tool "cppcheck" over
the source code of ghmm-0.7. It said many things, including

1.

[xmlwriter.c:395] -> [xmlwriter.c:395]: (style) Same expression on both sides of '&&'.

Source code is

if ((f->model.d[moNo]->s[sNo].xPosition > 0)
&& (f->model.d[moNo]->s[sNo].xPosition > 0)) {

Maybe the intended code is

if ((f->model.d[moNo]->s[sNo].xPosition > 0)
&& (f->model.d[moNo]->s[sNo].yPosition > 0)) {

2.

[xmlwriter.c:527] -> [xmlwriter.c:527]: (style) Same expression on both sides of '&&'.

Duplicate.

Discussion


Log in to post a comment.

MongoDB Logo MongoDB