Re: [ggt-devel] Pending patches

[Patrick H. <pa...@13...>]

On Mar 5, 2009, at 8:50 AM, Sebastian Messerschmidt wrote:

> Patrick Hartling schrieb:
>> Are there any pending GMTL patches remaining to be committed? If  
>> not, then I
>> am going to tag the current code base as GMTL 0.6.0 and make a  
>> release.
>>
>>  -Patrick
>>
>>
>>
> Sorry for the late response, but regarding my patch on the
> Intersection.h, I've introduced some oddity:
>
> in Intersection.h
> <snip>
>   template<typename T>
>   inline bool intersect( const Sphere<T>& sphere, const Ray<T>& ray,
> unsigned int& numhits, T& t0, T& t1 )
> </snip>
> around line 550
>
> the numhits = -1 should state numhits = 0
>
> to avoid compilers to barf at higher warning levels.

In the most current version of Intersection.h, that overload of  
intersect has numhits declared as a signed integer rather than as an  
unsigned. Initializing it to -1 is safe in that case.

  -Patrick


--
Patrick L. Hartling
Senior Software Engineer, Priority 5
http://www.priority5.com/