Re: [ggt-devel] Fix for broken isInVolume(AABOX, AABOX)

[Kevin M. <ke...@su...>]

is it for completely contained.   or just for intersection?   i forget... :(

---
kevin meinert | http://www.subatomicglue.com


On Thu, Feb 12, 2009 at 4:34 PM, Patrick Hartling <pa...@13...> wrote:

> On Feb 12, 2009, at 3:03 AM, Sebastian Messerschmidt wrote:
>
> > Hi folks,
> >
> > attached you'll find a patch for the isInVolume function testing two
> > axis-aligned boxes.
> >
> > The problem with the former algorithm had, was to rely on overlap
> > test only, which means that intersecting boxes were considered
> > containing each other.
> > I've rewritten the test, so it will work for all cases.
>
> After applying this patch, I get a failure in the test suite. The test
> case (see gmtlTest::AABoxContainTest::testIsInVolumeAABox() in the
> file Test/TestSuite/TestCases/AABoxContainTest.cpp) checks to see if
> box2 contains box3 where these boxes are defined as follows:
>
>    gmtl::AABoxf box2(gmtl::Point3f(30,30,30), gmtl::Point3f(40,40,40));
>    gmtl::AABoxf box3(gmtl::Point3f(35,35,35), gmtl::Point3f(37,37,37));
>
> Perhaps my expectation of gmtl::isInVolume() is wrong, but the
> documentation says that it should return true for the case when the
> second box (box3) is contained by the first (box2).
>
>  -Patrick
>
>
> --
> Patrick L. Hartling
> Senior Software Engineer, Priority 5
> http://www.priority5.com/
>
>
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco,
> CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the
> Enterprise
> -Strategies to boost innovation and cut costs with open source
> participation
> -Receive a $600 discount off the registration fee with the source code:
> SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> ggt-devel mailing list
> ggt...@li...
> https://lists.sourceforge.net/lists/listinfo/ggt-devel
>