[ggt-checkins] 5 testsuite errors down to 1 again

[Kevin M. <ke...@vr...>]

I fixed the 4 errors that the test suite had.  Justin, make sure I didn't 
break something in quat mult.  I seem to remember you had to swap around 
the mult function for some reason (to make *= work?), anyway, I found it 
computing the wrong value tonight, so I've checked in a fix for it (I had 
to swap the q1 and q2 in mult()).  This contributed to fixing the test 
suite as well.  (I had to manually fix a couple funcs).

Anyway, I'm not sure what happened, but stuff should be more accurate now.
Let me know if not.  For everyone, lets try not to ignore the errors in 
the future (anyone want to tackle testMatrixgetRotEuler?).  Next time you 
change something, just run the suite, thats what it's there for (its your 
friend).  announce anything that isn't yours, or fix it yourself, it 
usually doesn't take long.

- kevin

On Sun, 16 Mar 2003, Kevin Meinert wrote:

> subatomic    2003/03/16 20:04:44 PST
> 
>   Modified files:
>     modules/GMTL/gmtl    QuatOps.h 
>   Log:
>   swapped args on mult( Quat, Quat ) to match the matrix version (see test
>   QuatOpsTest::testQuatMult() in the test suite).  This change also
>   fixes a few broken test cases in the test suite.
>   
>   Fixed div( Quat, Quat ) to work right (see QuatOpsTest::testQuatDiv() in
>   the test suite)  it is defined as q1 * (1/q2).
>   
>   added / and /= for quat division.
>   
>   Revision  Changes    Path
>   1.22      +33 -24    GGT/modules/GMTL/gmtl/QuatOps.h
> 
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/ggt/GGT/modules/GMTL/gmtl/QuatOps.h.diff?r1=1.21&r2=1.22&diff_format=l
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by:Crypto Challenge is now open! 
> Get cracking and register here for some mind boggling fun and 
> the chance of winning an Apple iPod:
> http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en
> _______________________________________________
> ggt-checkins mailing list
> ggt...@li...
> https://lists.sourceforge.net/lists/listinfo/ggt-checkins
> 

-- 
*--*---*---*----*-----*------*------*-----*----*---*---*--*
Kevin Meinert                         /_/                  
home - http://www.vrsource.edu/~kevin           \        / 
music - http://subatomic.vrsource.org          \/  __    \/
                                                   \__     
                                            \_\