Re: [ggt-devel] Problems with the new pc files with 0.4.12 on RHEL 4 and scons 0.96.93

[Doug M. <mc...@ia...>]

>>>>>

[snip]

>>>>> It certainly would be nice. I had always assumed that the SCons
>>>>> function
>>>>> PkgConfigBuilder() was injecting them, but I never tried tracking
>>>>> down their
>>>>> exact source.
>>>>>
>>>>>
>>>>
>>>> I will take a look and see if I can create a patch.
>>>
>>> How about this patch?
>>
>> That's very interesting. I can see why re.escape() is being used in
>> that
>> context, but I wonder if it's truly necessary. There is no
>> indication in the
>> revision history or in the code of a specific reason that re.escape
>> () needs
>> to be used. It definitely is not needed for key given the
>> restrictions on
>> what key can be. For Windows, I can see where it would be  
>> important to
>> ensure that the backslash characters in a path would be handled
>> properly,
>> but that's the only case I can think of. That can be handled more
>> directly
>> using str.replace().
>>
> Your comment about Windows makes sense. Please let me know if the
> patch or a similar fix is committed. Thanks.


Any thoughts on this patch?

Doug