Re: [ggt-devel] makeZRot Fix

[Allen B. <al...@vr...>]

Thanks for the bug fix.  I have checked the change into CVS.

It looks like this section of code is not covered by the test suite.  Do 
you by chance have some code sitting around now that could be added to 
the test suites to make sure these methods keep working?

Thanks,
Allen

Todd J. Furlong wrote:

> I was trying to use gmtl::makeZRot, and it was giving me the same 
> result no matter what matrix it was given.  To resolve, I changed the 
> first line of the makeZRot function to read:
> const gmtl::Vec<DATA_TYPE, 3> forward_point(1.0f, 0.0f, 0.0f);   // +X
>
> The problem was that the forward_point was originally a vector along 
> the Z-axis, so rotation about that axis couldn't be measured using the 
> logic in that function.
>
> -Todd
>