From: Kevin M. <ke...@vr...> - 2003-04-18 16:33:00
|
Looks good. Just make sure the copy isn't needed on them (compiler should complain I think if you make it const and the func is writting to the data). kevin On Fri, 18 Apr 2003, Patrick Hartling wrote: > Here's the list I put together from the list of method instantiations > needed for Python: > > gmtl::makeNormal(gmtl::Vec) > gmtl::set(gmtl::AxisAngle&, gmtl::Quat) > gmtl::setRot(gmtl::AxisAngle&, gmtl::Quat) > > In the first case, I *think* the gmtl::Vec<S, T> parameter should be a > const reference. In the other two, I would think that the gmtl::Quat<T> > parameter should be a const reference, but this could be one of those > places where a copy is more appropriate. > > Ths list is shorter than I remember, but that's probably because there > are multiple variations of these instantiated based on the data types > used (float, double, etc.). > > -Patrick > > Ben Scott wrote: > > Patrick Hartling wrote: > > > > [snip] > > > >> P.S. There are several places where data types are being passed by > >> value where pass-by-reference behavior would be appropriate. I didn't > >> note where each of these is, but I should be able to find them in my > >> long list of function instantiations. > > > > > > Please do keep a list as you find them and let us know what they are. > > That way we can fix them if you don't. :) > > > > cheers, > > ----- > > Ben Scott > > Research Assistant > > VR Juggler Team > > Virtual Reality Applications Center > > bs...@vr... > > > > > > > > > > ------------------------------------------------------- > > This sf.net email is sponsored by:ThinkGeek > > Welcome to geek heaven. > > http://thinkgeek.com/sf > > _______________________________________________ > > ggt-devel mailing list > > ggt...@li... > > https://lists.sourceforge.net/lists/listinfo/ggt-devel > > > > -- *--*---*---*----*-----*------*------*-----*----*---*---*--* Kevin Meinert /_/ home - http://www.vrsource.edu/~kevin \ / music - http://subatomic.vrsource.org \/ __ \/ \__ \_\ |