Re: [ggt-devel] gmtl::makeInverse()

[Ben S. <bs...@ia...>]

It is an API change, but since the user never specifies the argument, 
they won't even notice the change. Also, the function is inlined in 
compiled code, so applications don't even have to worry about an ABI 
change. I think we should be OK with just bumping to 0.2.2.

cheers,
-Ben

Patrick Hartling wrote:
> Okay, the change is committed.  Since this changes the API, should the 
> version increase go to 0.3.0 or 0.2.2?  It removes a default argument 
> that I doubt anyone would have ever used, so 0.2.2 would probably be okay.
> 
>  -Patrick
> 
> Ben Scott wrote:
> 
>> You are right. makeInverse() shouldn't need Type2Type. The only reason 
>> I can think of that it might be there would be to work around a VC7 
>> compile error. However, I'm pretty sure that's not the case since I'm 
>> not seeing that in the CVS log.
>>
>> I give you the green light on removing the Type2Type. When you do 
>> though, make sure you modify the src argument to pass by const 
>> reference rather that const value. (I just noticed that error ...)
>>
>> cheers,
>> -Ben
>>
>> Patrick Hartling wrote:
>>
>>> Is there a reason that gmtl::makeInverse() (lines 1064-1070 of 
>>> Generate.h) uses the Type2Type idiom?  Just from looking at it, it 
>>> seems like there can be no ambiguity relating to overloading because 
>>> the return type always matches the parameter type.  Am I missing 
>>> something?
>>>
>>>  -Patrick
>>>
>>>
>>> P.S. I ask because the Type2Type thing doesn't work at all in 
>>> languages without generics (at least AFAICT), and the fewer places I 
>>> have to write wrappers, the better.
>>>
>>>
>>
>>
>>
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by:
>> The Definitive IT and Networking Event. Be There!
>> NetWorld+Interop Las Vegas 2003 -- Register today!
>> http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
>> _______________________________________________
>> ggt-devel mailing list
>> ggt...@li...
>> https://lists.sourceforge.net/lists/listinfo/ggt-devel
> 
> 
> 
>