Re: [Geotools-devel] Removing themes from Viewer

[James M. <j.m...@ge...>]

You are quire correct the there was a problem and your solution seems spot 
on, feel free to commit your changes.

The reason this has happened is because of a recent internal change in 
Viewer which used to track the position and visibility of themes 
itself.  This has now been moved into the ThemeStack object, but clearly I 
missed the changes which were needed to the removeTheme method.  Many 
thanks for the fix.

It should be possible to remove all references to the visibleThemes and the 
staticThemes vectors from Viewer now, but as there may be some external 
classes which depend upon them this would need careful checking.

James

At 02:28 PM 12/12/01 +0800, you wrote:
>Hihi,
>
>I have some problem with removing an existing theme from the viewer.
>When I called Viewer.remove(Theme), the shapes in the theme are still
>visible, although I can not highlight or select them. and the corresponding
>ThemePanel does not update, either.
>I looked throught the source code of Viewer.java, and found that when a
>theme is remove, it is not removed from themeStack. Since I am not very
>familiar with the codes in Viewer.java, I am not sure whether this is a bug,
>or there is some other tricks. However, after I made the following changes,
>the removing of themes seems to be working.