Re: [Geotools-devel] Do we have a page about contributing a patch?

[Ian T. <ijt...@gm...>]

On 31 August 2012 11:03, Jody Garnett <jod...@gm...> wrote:
> It does and we do.
>
> However we have several sections of the codebase that have been formatted by
> hand. As such when you blindly do "Alt-Shift-F" you introduce
> a lot of noise into your patch.

In which case we should tell the auto formatter not to modify those
sections (http://stackoverflow.com/questions/1820908/how-to-turn-off-the-eclipse-code-formatter-for-certain-sections-of-java-code)

>
> Why does this matter? It basically screws anyone who is trying to apply the
> patch across different branches / releases.
>
> My guess is that by doing the whitespace change is a separate patch; Justin
> would be able to "cherry-pick" just the change with the fix across to a
> different release.

I understand why this is bad - I just thought we sorted the issue some
years ago.

Ian