Re: [Geotools-devel] [Geoserver-devel] How to use "anonymous" OGC Filter Functions

[Gabriel R. <gr...@op...>]

On Wed, Jul 11, 2012 at 10:40 AM, Andrea Aime
<and...@ge...> wrote:
> On Wed, Jul 11, 2012 at 1:49 AM, Gabriel Roldan <gr...@op...> wrote:
>
>>> The problem is not the immutability of the object itself, but the one of its
>>> parameters. During simplification one might notice one of the parameters
>>> is a constant and replace it with it, but if the function itself has to
>>> be managed as immutable that simplification would be impossible.
>>
>> right, but my use case doesn't involve any parameters at all.
>
> I understand your use case, but when rolling new public API stuff has
> to make sense in general.
>
> I believe what Jody suggested is a good general solution that also
> addresses the issues that Justin saw with dynamic languages,
> requires just a bit more effort in that you'll probably have to turn
> your inner classes into package private ones

Sounds good to me. That's the kind of feedback I was looking for, thanks all.
So, I'll create a jira issue and attach a patch in there for review.

Cheers,
Gabriel
>
> Cheers
> Andrea
>
>
> --
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
>
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax:      +39 0584 962313
> mob:    +39 339 8844549
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf



-- 
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.