Re: [Geotools-devel] wfs 2.0 work review

[Justin D. <jde...@op...>]

Hey Jody,

Can you not use my gmail address. Thanks :)

On Tue, Oct 11, 2011 at 8:20 AM, Jody Garnett <jod...@gm...>wrote:

>  Hi Justin:
>
> I got stuck at work and did not get a chance to review - but tomorrow is
> looking good. And I would like to sort out a way to be helpful as this is a
> massive chunk of work.
>
> What I will do is:
> a) Make a release (done!)
> b) Break your email down into some RFC pages (so people can talk about
> PropertyIsNIL and leave the rest alone).
> c) Go through your patches and see what I can see
>

At this point review getting things reviewed has been the blocker. Big
thanks to Andrea and Christian who have been working on reviewing the patch
for joins, which is definitely the biggest chunk of work.

>
> I was not too fused over PropertyIsNIL?
>

Regarding PropertyIsNil we came to the agreement that its not worth spending
a lot of time on it now, we'll wait until someone has a use case for it or
app-schema needs it, etc... So for now PropertyIsNil will simply just pass
through to PropertyIsNull.

>

> The only thing that looked strange to me was the "extended operators"
> (where I would really like to use the existing FunctionFactory in order to
> leverage what we have and avoid adding new API). With that in mind: we could
> just use the FunctionFactory straight up; or we could let it return a second
> list of FunctionName called getOperatorNames(): List<FunctionName>.
>

Yup, that was agreed upon as well. Basically I just need to make function
names qualified (for which a patch has already been posted and has one +1).
If you wanted to review that patch that would be great.

http://jira.codehaus.org/browse/GEOT-3871


> Is anyone else available tomorrow as I would like to tag team this work a
> bit so we can get through it?
> --
> Jody Garnett
>
> --
> Jody Garnett
>
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2d-oct
> _______________________________________________
> Geotools-devel mailing list
> Geo...@li...
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.