From: Andrea A. <aa...@op...> - 2007-10-16 09:49:59
|
Hi, I'm in kind of urgent need of a close method in jdbc datastores so it's possible to have the connection pool closed down when the datastore is about to be killed, without waiting for the garbage collector to run the finalizer in JDBC2DataStore (which does the same). (http://svn.geotools.org/geotools/trunk/gt/modules/library/jdbc/src/main/java/org/geotools/data/jdbc/JDBC2DataStore.java) Now, I'm inclined to add a close() method right into JDBC2DataStore and do an instanceof check in geoserver, since we definitely cannot afford changing the datastore api now. Can I proceed? This won't impede improving the datastores in the future (and having a close method is a well know item in the datastore api wish list). Cheers Andrea |