From: Andrea A. <aa...@op...> - 2007-09-15 17:02:49
|
Jody Garnett ha scritto: > Hi Andrea; I am afraid you missed the part we needed your help on - > choose between these code examples. I fear you did not read the place in my mail where I talk about it: "About the Feature.getDefaultGeometry(), I prefer this alternative compared to getDefaultGeometryProperty() but... there is a big but! In 2.4.x we deprecated getDefaultGeometry() and replaced with getPrimaryGeometry(). Now we go back? Do whatever you please, but please, don't ask library users to change that method name two times!! (same goes for SimpleFeatureType)." So I already expressed my vote to favour getDefaultGeometry(), it's just that none of the options you provided matches the changes that have just been performed on gt2 (getPrimaryGeometry()). And I want to underline, whilst I have a small preference for getDefaultGeometry, that's not the important thing, the important thing is that whatever name you choose must be back ported to 2.4.x before we release in order to avoid changing that method twice in two subsequent releases. Cheers Andrea |