[Geotools-devel] Please be carefull with public API

[Martin D. <mar...@ge...>]

Noticed a new addition in ColorUtilities:

    public static BigInteger expand(final Color[] colors, final int[] ARGB,
            final int lower, final int upper, BigInteger bits)
    {
        for (int i=lower; i<upper; i++) {
            bits = bits.setBit(i);
        }
        ColorUtilities.expand(colors, ARGB, lower, upper);
        return bits;
    }

Compared to the existing method, this new method adds a 'bits' additional
arguments. But the javadoc said absolutly nothing about the purpose of this
argument. Looking at the code, it seems to mix unrelated tasks. Why the loop is
not in a separated method, something like XMath.setAllBits(int lower, int upper)
method?


	Martin