Re: [Geotools-devel] Trunk broken? and fear of module split

[Chris H. <ch...@op...>]

Quoting Martin Desruisseaux <mar...@no...>:

> Chris Holmes a =E9crit :
> > First cruise control seems to be spitting failure messages at us,
> and
> > when I do 'maven build' I get a bunch of compile errors on main,
>
> Trunk build fine for me too, both using Maven 1 and Maven 2. Could
> you
> tell us about the error message you get?
>
> Note that because of the new module addition (referencing, coverage,
> api), "maven clean" will not work until you get a successfull "maven
> install". It seems to be a kind of Maven bug to me. Cruise Control
> fails
> exactly for this reason (it try to performs a "maven clean" before
> "maven install"). It need a manual "maven install" (without "maven
> clean"), but I believe that only James has administrator rights for
> performing this task. As long as this task is not done, Cruise
> Control
> will still broken.
I'll fully clean and install again, I'm sure it's probably just me.

>
>
> > when I do 'maven jar:install' in a module, I don't seem to get the
> > tests running any more?  Is that intentional?  How do I get them to
> > run?
>
> The tests should continue to be run... Which module did you tried?
Several of them.  I'll give it another try though.

>
>
> > Also, I'm a bit in fear of this module split.  From what I see now
> we
> > have 'api', which sounds good, bring back the old 'core', get
> > everything shifted to GeoAPI.  But, uh, it _depends_ on coverage?
> Oh
> > wait, I think it doesn't actually, it's just in the project.xml?
>
> API doesn't depends on coverage. I guess that the coverage dependency
> in
> project.xml is a remanescence of a copy-and-paste from main (I'm not
> the
> one who did the api split). Note that pom.xml (the Maven 2 project
> file)
> do not contains this coverage dependency.
Cool.

>
> I maintain the Maven 2 build, but I do not maintain the Maven 1 build
> and really do not want to put any energy on it (it seems a little bit
> chaotic to me). In the Maven 2 build, I put some energy in trimming
> down
> the dependencies, including for the new 'api' module.
Wait, so Maven 2.0 is out?  Like not release candidate?  And it's
better, no?  And Martin's willing to be the build master?  It seems
silly to maintain two versions, if 2.0 is actually out, no?

>
> I would like to move as much as we can from 'api' module to geoapi at
> some later stage. But the GeoAPI process is slower than Geotools,
> which
> is in my understanding the main reason why 'api' exists.
Yes, very much agree.

>
> I have not checked why 'api' depends on 'referencing'. I suspect that
> yours hypothesis is right (maybe it depends of org.geotools.factory).
> If
> this is true, we could move the org.geotools.factory package
> somewhere
> else.
Yeah, I tried to build with the referencing dependancy removed, and it
failed on the factory stuff.

> But I would rather investigate if there is anyway to completly
> avoid a 'org.geotools.factory' dependency in 'api'. If the 'api'
> module
> is only about interfaces, it should not contains any implementation.
> And
> if it doesn't contains any implementation, then it shouldn't need to
> look for factories.
This sounds sensible to me.

thanks Martin,

Chris

>
> 	Martin.
>




----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/