Menu
▾
▴
[Geoserver-devel] [jira] (GEOS-5384) WPSException - can't set exceptionCode and locator value
|
From: Mark L. (JIRA) <ji...@co...> - 2012-10-30 18:47:20
|
<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#ffffff" style="background-color:#ffffff;color:#00AA00;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://www.codehaus.org/codehaus-small.gif" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://jira.codehaus.org/secure/useravatar?avatarId=10232" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="mlague" id="email_mlague" href="https://jira.codehaus.org/secure/ViewProfile.jspa?name=mlague" style="color:#005500;">Mark Lague</a>
created <img src="https://jira.codehaus.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#005500;text-decoration:none;' href='https://jira.codehaus.org/browse/GEOS-5384'>GEOS-5384</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#005500;text-decoration:none;' href='https://jira.codehaus.org/browse/GEOS-5384'><strong>WPSException - can't set exceptionCode and locator value</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://jira.codehaus.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> Bug
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Versions:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
2.2-RC3 </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Assignee:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="aaime" id="email_aaime" href="https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime" style="color:#005500;">Andrea Aime</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Components:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
WPS </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Created:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
30/Oct/12 1:46 PM
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<p style='margin-top:0;margin-bottom:10px;'>I created a new WPS process with some validation methods.</p>
<div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent">
<pre>package ca.gc.nrcan.egp;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.logging.Logger;
import javax.mail.internet.AddressException;
import javax.mail.internet.InternetAddress;
import org.geoserver.wps.WPSException;
import org.geoserver.wps.gs.GeoServerProcess;
import org.geotools.geometry.jts.JTSFactoryFinder;
import org.geotools.process.ProcessException;
import org.geotools.process.factory.DescribeParameter;
import org.geotools.process.factory.DescribeProcess;
import org.geotools.process.factory.DescribeResult;
import com.vividsolutions.jts.geom.GeometryFactory;
import com.vividsolutions.jts.geom.Polygon;
import com.vividsolutions.jts.io.ParseException;
import com.vividsolutions.jts.io.WKTReader;
@DescribeProcess(title="VectorExtractionWPS", description="Extraction service for vector data")
public class VectorExtractionWPS implements GeoServerProcess {
private static Logger log = Logger.getLogger(VectorExtractionWPS.class.getName());
@DescribeResult(name="result", description="output result")
public String execute(
@DescribeParameter(name="layers", description="name of the layers to clip") String layers,
@DescribeParameter(name="outputFormat", description="output format of the spatial dataset") String outputFormat,
@DescribeParameter(name="delineation", description="outline used for clipping") String delineation,
@DescribeParameter(name="email", description="email address") String email)
{
validateEmail(email);
validateWKT(delineation);
validateLayers(layers);
validateOutputFormat(outputFormat);
return SubmitToLSF.BSUBvector(layers, outputFormat, delineation, email);
}
static void validateWKT(String wkt) {
Double maxArea = new Double(50.00);
GeometryFactory geoFac = JTSFactoryFinder.getGeometryFactory(null);
WKTReader reader = new WKTReader(geoFac);
try {
Polygon polygon = (Polygon) reader.read(wkt);
if (polygon.isEmpty()) {
throw new WPSException("empty polygon", "InvalidParameterValue", "delineation");
}
if (!polygon.isValid()) {
throw new WPSException("invalid polygon", "InvalidParameterValue", "delineation");
}else {
Double area = polygon.getArea();
if (area > maxArea) {
throw new WPSException("polygon to big", "InvalidParameterValue", "delineation");
}
}
}catch (ParseException e) {
log.info("validationWKT exception : " + e.getMessage());
}
}
static void validateEmail(String email) {
try {
InternetAddress emailAddr = new InternetAddress(email);
emailAddr.validate();
}catch(AddressException e) {
log.info("validateEmail exception : " + e.getMessage());
throw new WPSException(e.getMessage(), "InvalidParameterValue", "email");
}
}
static void validateLayers(String layers) {
ArrayList<String> layerList = new ArrayList<String>(Arrays.asList("bs", "en", "fo", "hd", "ic", "la", "li", "lx", "ss", "to", "tr", "ve"));
List<String> layerError = new ArrayList<String>();
String[] ll = layers.split(",");
for (int i = 0; i < ll.length; i += 1) {
if (!layerList.contains(ll[i].toLowerCase())) {
layerError.add(ll[i]);
}
}
throw new WPSException("invalid layer(s)", "InvalidParameterValue", layerError.toString());
}
static void validateOutputFormat(String outputFormat) {
ArrayList<String> formatList = new ArrayList<String>(Arrays.asList("geodatabase_file", "shape", "geojson", "gml2"));
if (!formatList.contains(outputFormat.toLowerCase())) {
log.info("validateOutputFormat exception : invalid output format " );
throw new WPSException("invalid output format", "InvalidParameterValue", outputFormat);
}
}
}
</pre>
</div></div>
<p style='margin-top:0;margin-bottom:10px;'>The validation methods throw a WPSException when there's an invalid parameter. I'm setting the exceptionCode and locator value on the WPSException, but when I call the service with any type of error I always receive this message (the only thing that changes is the text in ows:ExceptionText which is always doubled!):</p>
<div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent">
<pre><?xml version="1.0" encoding="UTF-8"?>
<wps:ExecuteResponse xml:lang="en" service="WPS" serviceInstance="http://localhost:8080/geoserver/ows?" version="1.0.0">
<wps:Process wps:processVersion="1.0.0">
<ows:Identifier>gs:VectorExtractionWPS</ows:Identifier>
<ows:Title>VectorExtractionWPS</ows:Title>
<ows:Abstract>Extraction service for vector data</ows:Abstract>
</wps:Process>
<wps:Status creationTime="2012-10-30T15:35:54.335Z">
<wps:ProcessFailed>
<ows:ExceptionReport version="1.1.0">
<ows:Exception exceptionCode="NoApplicableCode">
<ows:ExceptionText>Process failed during execution org.geoserver.wps.WPSException: Invalid email address Invalid email address</ows:ExceptionText>
</ows:Exception>
</ows:ExceptionReport>
</wps:ProcessFailed>
</wps:Status>
</wps:ExecuteResponse>
</pre>
</div></div>
<p style='margin-top:0;margin-bottom:10px;'>Is this a bug or am I missing something in my code?</p>
<p style='margin-top:0;margin-bottom:10px;'>Thanks for any help,</p>
<p style='margin-top:0;margin-bottom:10px;'>Mark</p>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Environment:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
war package deployed in Tomcat server 7.0 on a Windows XP OS
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Project:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a style="color:#005500;" href="https://jira.codehaus.org/browse/GEOS">GeoServer</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Priority:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://jira.codehaus.org/images/icons/priority_minor.gif" height="16" width="16" border="0" align="absmiddle" alt="Minor"> Minor
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Reporter:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="mlague" id="email_mlague" href="https://jira.codehaus.org/secure/ViewProfile.jspa?name=mlague" style="color:#005500;">Mark Lague</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#005500;' href='https://jira.codehaus.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#005500;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->
|
![http://www.codehaus.org/codehaus-small.gif"](http://www.codehaus.org/codehaus-small.gif"){kind=link}
![https://jira.codehaus.org/images/icons/bug.gif"](https://jira.codehaus.org/images/icons/bug.gif"){kind=link}
![https://jira.codehaus.org/images/icons/priority_minor.gif"](https://jira.codehaus.org/images/icons/priority_minor.gif"){kind=link}