#1 GeoIP-Python Improvements

closed
nobody
None
5
2008-06-04
2008-01-03
No

Attached is a patch that makes the following improvements to the GeoIP-Python binding:

1. fixes some reference leaks in setting up GeoIP.country_codes, country_names, and country_continents variables. It also moves some variable declarations to the top of the initGeoIP() function for compatibility with pre-C99 compilers.

2. exposes CHECK_CACHE and INDEX_CACHE flags for GeoIP.new() or GeoIP.open()

3. adds "database_info" and "database_edition" attributes to GeoIP objects.

4. adds "region_name" and "time_zone" keys to dictionary returned by record_by_addr()/record_by_name().

The patch is made against the current CVS version. Would it be possible to get this committed and a new release made?

Thanks.

Discussion

  • James Henstridge

    Logged In: YES
    user_id=146903
    Originator: YES

    I've updated the patch to match the recent changes in CVS. Could someone review this patch and commit it?
    File Added: geoip-python-improvements-2.patch

     
  • James Henstridge

    • status: open --> closed
     
  • James Henstridge

    Logged In: YES
    user_id=146903
    Originator: YES

    Marking closed, since Boris has applied the patch.

     

Log in to post a comment.