Re: [Geoip-java] LookupService - most of the methods are "synchronized"

[Thomas J M. <tjm...@ma...>]

I think they are done sequentially.

Patches are welcome if you would like the benchmark test to have
concurrency tests.

As far as I know, no one has reported performance issues with the
synchronized code.

-TJ

On Mon, Jul 16, 2012, at 01:13 PM, Yuval Ryaboy wrote:
> BTW, are your performance tests for java based on BenchmarkGeoIP.java
> class?
> If so, these are not the real concurrency tests because all the calls are
> done sequentially. Although more time is spent entering "synchronized"
> section no real locks between threads are performed.
> 
> 
> Thanks,
> Yuval
> 
> -----Original Message-----
> From: Yuval Ryaboy 
> Sent: Sunday, July 15, 2012 10:58
> To: 'Thomas J Mather'
> Cc: geo...@li...
> Subject: RE: [Geoip-java] LookupService - most of the methods are
> "synchronized"
> 
> Hi ,
> 
> Can you please explain what are the variable that are being protected by
> the "synchronized" using the GEOIP_MEMORY_CACHE option.
> Maybe we can reduce the amount of protected code by "synchronized" the
> relevant lines and this way increase the performance.
> 
> 
> Thanks a lot,
> Yuval
> 
> -----Original Message-----
> From: Thomas J Mather [mailto:tjm...@ma...]
> Sent: Thursday, July 12, 2012 19:46
> To: Yuval Ryaboy; geo...@li...
> Subject: Re: [Geoip-java] LookupService - most of the methods are
> "synchronized"
> 
> Even with synchronized methods, the API should still be fast, we
> benchmarked it here:
> http://www.maxmind.com/app/benchmark
> 
> -TJ
> 
> On Thu, Jul 12, 2012, at 12:06 PM, Yuval Ryaboy wrote:
> > Hi All,
> > 
> > I am trying to integrate the java implementation but from what I see 
> > most of the methods in "LookupService" are "synchronized", which 
> > promises a real bad performance.
> > My question is does anyway have a better implementation or fixed this 
> > one (I am planning to use memory cache)?
> > 
> > Thanks  a lot,
> > Yuval
> > ----------------------------------------------------------------------
> > --------
> > Live Security Virtual Conference
> > Exclusive live event will cover all the ways today's security and 
> > threat landscape has changed and how IT managers can respond.
> > Discussions will include endpoint security, mobile security and the 
> > latest in malware threats.
> > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> > _______________________________________________
> > Geoip-java mailing list
> > Geo...@li...
> > https://lists.sourceforge.net/lists/listinfo/geoip-java
> 
>