#87 Gentoo-020.6 changing bkground and forground color only applies to primary face

[RickTee]

Gentoo-020.6

Configuring button colors only gets applied to primary buttons using either primary->background/foreground or secondary->background/foreground buttons cfg color selection buttons. The only reason some will have colored secondary buttons is where the colors were already set in an old config.

Error seems to be:
cfg_buttons.c
Lines: 728 & 734 (line numbers may not be accurate due to debug statments being added to trace the error)
Code:
728: g_object_set_data(G_OBJECT(def->col_bg), "face", GINT_TO_POINTER(0));
734: g_object_set_data(G_OBJECT(def->col_fg), "face", GINT_TO_POINTER(0));

Fix seems to be change these lines to:
728: g_object_set_data(G_OBJECT(def->col_bg), "face", GINT_TO_POINTER(face));
734: g_object_set_data(G_OBJECT(def->col_fg), "face", GINT_TO_POINTER(face));

I have the same issue with v0.15.6 which suggests this bug has been with us for a while.

[RickTee]

I have changed the code in odmultibutton.c: od_multibutton_reset_label() so that background color is applied to the button using CSS (Gtk3.14) instead of the label, which I think looks much better. If you want it let me know I'll try to figure out how to make a patch, failing that send the file. :)

[Emil Brink]

Hi!

Thanks, that sounds interesting. Is it possible to attach the code to the
issue?

Also apologies for the positively glacial "speed" at which gentoo is
"developed" these days.

Regards,

/Emil

On Sun, Jan 31, 2016 at 12:59 PM, RickTee ricktee@users.sf.net wrote:

I have changed the code in odmultibutton.c: od_multibutton_reset_label()
so that background color is applied to the button using CSS (Gtk3.14)
instead of the label, which I think looks much better. If you want it let
me know I'll try to figure out how to make a patch, failing that send the
file. :)

---

[bugs:#87] Gentoo-020.6 changing bkground and forground color only
applies to primary face

Status: open
Group: v1.0 (example)
Created: Sun Jan 31, 2016 11:47 AM UTC by RickTee
Last Updated: Sun Jan 31, 2016 11:47 AM UTC
Owner: Emil Brink

Gentoo-020.6

Configuring button colors only gets applied to primary buttons using
either primary->background/foreground or secondary->background/foreground
buttons cfg color selection buttons. The only reason some will have colored
secondary buttons is where the colors were already set in an old config.

Error seems to be:
cfg_buttons.c
Lines: 728 & 734 (line numbers may not be accurate due to debug statments
being added to trace the error)
Code:
728: g_object_set_data(G_OBJECT(def->col_bg), "face", GINT_TO_POINTER(0));
734: g_object_set_data(G_OBJECT(def->col_fg), "face", GINT_TO_POINTER(0));

Fix seems to be change these lines to:
728: g_object_set_data(G_OBJECT(def->col_bg), "face",
GINT_TO_POINTER(face));
734: g_object_set_data(G_OBJECT(def->col_fg), "face",
GINT_TO_POINTER(face));

I have the same issue with v0.15.6 which suggests this bug has been with
us for a while.

---

Sent from sourceforge.net because you indicated interest in <
https://sourceforge.net/p/gentoo/bugs/87/>

To unsubscribe from further messages, please visit <
https://sourceforge.net/auth/subscriptions/>

[RickTee]

Not quite sure what code you wanted, the fix for the bug is the two lines as show above.

Erm bit embaressed about this. In the process of learning Gtk, reading through the source code found some things that made me rewrite the little game I've been working on, result was I got a bit carried away with odmultibutton.c and erm changed some more things. :) Anyway its attached, hope you don't mind.

[Emil Brink]

Hi.

Just wanted to note that I have indeed applied this change, after minimal local verification, and it (not surprisingly) fixes the bug. Which really was scary.

Thanks for your interest in gentoo and for taking the time to not only report, but also figure out the fix.

Haven't done a new release just for this, I have some other bits floating around that would be good to address.