Menu

JAnnot library Merge Request #11: FindBugs checks (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

darolmar wants to merge 1 commit from /u/darolmar/genomeview/ to master, 2013-12-01

FindBugs checks

Commit Date  
[16b091] (HEADmaster) by darolmar darolmar

Bug: net.sf.jannot.source.SAMDataSource$SAMKey.equals(Object) does not
check for null argument
This implementation of equals(Object) violates the contract defined by
java.lang.Object.equals() because it does not check for null being
passed as the argument. All equals() methods should return false if
passed a null value

Bug: net.sf.jannot.MemoryFeatureAnnotation.toString() may return null
This toString method seems to return null in some circumstances. A
liberal reading of the spec could be interpreted as allowing this, but
it is probably a bad idea and could cause other code to break. Return
the empty string or some other appropriate string rather than null.

Bug: net.sf.jannot.source.DataSourceFactory$Sources.toString() may
return null
This toString method seems to return null in some circumstances. A
liberal reading of the spec could be interpreted as allowing this, but
it is probably a bad idea and could cause other code to break. Return
the empty string or some other appropriate string rather than null.

2013-12-01 16:22:08 Tree

Discussion


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.