Re: [GeneX-dev] RCluster fixes, release delays

[<ja...@op...>]

"Greg D. Colello" <gd...@nc...> writes:

> Hey. That's good news.
> 
> >I've checked in some major changes to rcluster. Sorry no code
> >improvements, just installation improvements. It is now completely
> >integrated into the rest of the installation process, and I even fixed
> >a bug along the way.

Maybe yes, maybe no. I hope it was good. In the short run it was
stupid. I could have broken it completely. I was just so irritated at
having CVS tell me that I had modified rcluster files that I hadn't
checked in, when I didn't.

Andrew Dalke is very clever. And I recognize a pattern that he and I
share, we can easily find ways to fix problems that often works
complete around the way things were intended to be done. Andrew
created some really elaborate installation stuff that he didn't need
to. Perl will do most of it for you if you let it. Because Andrew's
code wasn't letting Perl handle the installation, things were overly
complex.

So: 
1) I gave all his modules an appropriate namespace under RCluster::*
   (appropriate meaning they all live in the unifying RCluster::
   namespace, and they all begin with a capital Letter -- all
   lowercase module names should be reserved for compiler pragmas). 
2) I also removed his file substitution mechanism, and used the one
   built in to the installer (all files with substitutable parameters
   start life as a '.in' file, e.g. configure.pl.in, then the
   substitution program takes all .in files, substitutes any
   parameters and creates the real file, e.g. configure.pl). That way
   we have all the .in files checked into CVS, and *not* the files
   with your installation-specific information in them. 

This was the piece that ticked me off so much, Andrew's substitution
mechanism modified the CVS files *in-place*, so CVS thought I had code
changes that needed to be checked in.

So, like I said the module organization is still as confusing as ever,
8 different modules that are only about 100 lines long and all seem to
include each other, but at least the installation is cleaner...

jas.