gemstracker-svn

[Gemstracker-svn] SF.net SVN: gemstracker:[317] branches/userloader/classes/Gems/Project/ ProjectSettings.php

[<gem...@li...>]

Revision: 317
          http://gemstracker.svn.sourceforge.net/gemstracker/?rev=317&view=rev
Author:   mennodekker
Date:     2011-11-30 13:14:29 +0000 (Wed, 30 Nov 2011)
Log Message:
-----------
Fixing notices

Modified Paths:
--------------
    branches/userloader/classes/Gems/Project/ProjectSettings.php

Modified: branches/userloader/classes/Gems/Project/ProjectSettings.php
===================================================================
--- branches/userloader/classes/Gems/Project/ProjectSettings.php	2011-11-30 10:33:50 UTC (rev 316)
+++ branches/userloader/classes/Gems/Project/ProjectSettings.php	2011-11-30 13:14:29 UTC (rev 317)
@@ -268,7 +268,7 @@
      */
     public function getSuperAdminName()
     {
-        if (isset($this->admin['user'])) {
+        if (isset($this->admin) && isset($this->admin['user'])) {
             return $this->admin['user'];
         }
     }
@@ -280,7 +280,7 @@
      */
     protected function getSuperAdminPassword()
     {
-        if (isset($this->admin['pwd'])) {
+        if (isset($this->admin) && isset($this->admin['pwd'])) {
             return $this->admin['pwd'];
         }
     }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Gemstracker-svn] SF.net SVN: gemstracker:[318] branches/userloader/classes/Gems/Project/ ProjectSettings.php

[<gem...@li...>]

Revision: 318
          http://gemstracker.svn.sourceforge.net/gemstracker/?rev=318&view=rev
Author:   mennodekker
Date:     2011-11-30 13:19:06 +0000 (Wed, 30 Nov 2011)
Log Message:
-----------
Added TODO after seeing a lot of notices that are fixed in the previous commit and having troubles in unit testing

Modified Paths:
--------------
    branches/userloader/classes/Gems/Project/ProjectSettings.php

Modified: branches/userloader/classes/Gems/Project/ProjectSettings.php
===================================================================
--- branches/userloader/classes/Gems/Project/ProjectSettings.php	2011-11-30 13:14:29 UTC (rev 317)
+++ branches/userloader/classes/Gems/Project/ProjectSettings.php	2011-11-30 13:19:06 UTC (rev 318)
@@ -97,6 +97,8 @@
 
         parent::__construct($array, ArrayObject::ARRAY_AS_PROPS);
 
+        //@@TODO: some checks should not be done on each and every request!
+        //        this can be a problem when testing
         $this->checkRequiredValues();
     }
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.