#86 [Core] Fix compilation for MSVC [1/3]

closed-works-for-me
5
2007-03-14
2007-01-28
No

Hi!

After a long time I decided to try compiling GemRB again on MSVC. I noticed some small problems, which are easily fixable. Although I could have committed them right away, I think it's better to post them here for review first.

Patch 1/3:

win32def.h should include <cstdlib>. This is assumed in some other files which don't explicitly include <cstdio> themself, so I thought the easiest fix is to simply include it here.

Discussion

  • Laszlo Toth

    Laszlo Toth - 2007-01-31

    Logged In: YES
    user_id=885460
    Originator: NO

    I'm not entirely sure about this, i'll have to check if this won't break other msvc compilations.
    I did not need this for compiling on msvc6.0 or msvc7.2
    What version you got?

     
  • Michael Drueing

    Michael Drueing - 2007-01-31

    Logged In: YES
    user_id=25917
    Originator: YES

    okay, obviously I meant <cstdlib> instead of <cstdio>.
    I'm using MSVC8 (MSVC 2005).

    I might take another look and put the "#include <cstdlib>" into the .cpp files instead of a global header, I guess that's the better solution.

     
  • Laszlo Toth

    Laszlo Toth - 2007-02-27
    • assigned_to: nobody --> avenger_teambg
    • status: open --> pending-works-for-me
     
  • Laszlo Toth

    Laszlo Toth - 2007-02-27

    Logged In: YES
    user_id=885460
    Originator: NO

    Ok, the code compiles for me on msvc 7 and 6 too, so i don't see the need for this patch.

     
  • SourceForge Robot

    • status: pending-works-for-me --> closed-works-for-me
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks