#116 fix for bug 1895628 (PC don't realize monsters are dead)

closed-fixed
5
2008-11-11
2008-10-04
No

Here is the patch, checking if lastTarget has really died :)

Discussion

  • Jérôme Gardou

    Jérôme Gardou - 2008-10-04

    this one is not correct :/ I'll rework on this later.

     
  • Jérôme Gardou

    Jérôme Gardou - 2008-10-04
    • status: open --> wont-fix
     
  • Jérôme Gardou

    Jérôme Gardou - 2008-10-11
    • status: wont-fix --> open
     
  • Jérôme Gardou

    Jérôme Gardou - 2008-10-11

    This one seems better. GameControl->TryToAttack uses the "Attack" action, instead of the magical "NIDSpecial3"
    If there is any reason to keep NIDSpecial3, please explain !!!
    File Added: attack_patch2.txt

     
  • Laszlo Toth

    Laszlo Toth - 2008-10-15

    The second patch seems to contain only the Nidspecial3 change. Could you please make a single consolidated patch for review?

     
  • Laszlo Toth

    Laszlo Toth - 2008-10-15

    I think i fixed this problem, but not exactly how this patch suggested.
    The first patch is not needed.
    We could discuss the second patch about NIDSpecial3, why is it needed?

     
  • Jérôme Gardou

    Jérôme Gardou - 2008-11-02

    It is not needed. Applying it alone fixed the bug, but introduced a new one : it seems that not all actors have a script name...

     
  • Laszlo Toth

    Laszlo Toth - 2008-11-11

    Yes, that's what the NidSpecial3 hack is about (also some scripting names are assigned to multiple actors). Everything that the user can select with point&click should rather use the direct object assignment trick used here, than redirecting via scripting names.
    So, i close this thread.

     
  • Laszlo Toth

    Laszlo Toth - 2008-11-11
    • labels: --> Engine Source
    • assigned_to: nobody --> avenger_teambg
    • status: open --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks