#190 Find duplicates window update regression

open
nobody
None
5
2015-04-07
2013-01-30
No

There is some regression in Geeqie 1.1 compared with 1.0:

1.) open "File > Find duplicates ..." window
2.) drag a folder, which contains a few test duplicate files, into the window
3.) select one file of a pair of dupes
4.) choose "Delete..." via right-click menu, or press Ctrl+D
5.) in the "Delete files?" dialog, choose the "Delete" button

What happens? The file gets deleted, but the "Find duplicates" window isn't updated. The file remains in the list of dupes. Similarly for the "Rename..." action. The new file name is not displayed automatically (only after rechecking manually via the "Compare by" box).

In Geeqie 1.0, after deleting the file, the corresponding entry in the "Find duplicates" window disappears automatically.

Related

Bugs: #190

Discussion

  • Michael Schwendt

    What happens is that dupe.c dupe_notify_cb() gets called with a NULL fd->change value, which results in an early return.

    Reverting the change in filedata.c file_data_send_notification(), the problem is gone, ... hmmm ...

     
  • - 2013-11-03

    I'm getting this too. Makes the duplicate search pretty hard to use effectively. (Ubuntu 13.10, 1:1.1-7 from official Saucy repo)

    How should I apply that change manually?

     
  • - 2013-11-03

    Thanks.

     
  • Paul E Johnson

    Paul E Johnson - 2013-11-04

    I confirm the patch here applies cleanly on Debian Wheezy's packing for geeqie and it fixes the problem I reported as http://sourceforge.net/p/geeqie/bugs/193/

     
  • Michael Schwendt

    Still reproducible with 1.2 from gitorious.

     
  • Simon Dedman

    Simon Dedman - 2015-04-07

    Sorry if stupid: I'm trying to apply this patch & I can't for the life of me find filedata.c
    I'm using 1.1 ubuntu software centre standard install.
    Thanks in advance!

     
  • Paul E Johnson

    Paul E Johnson - 2015-04-07

    You patch the source code. Not the installed package. Google for 'apt get source' and package builds with tool like dpkg build package.

    On April 7, 2015 4:26:39 PM CDT, Simon Dedman sharky-pi@users.sf.net wrote:

    Sorry if stupid: I'm trying to apply this patch & I can't for the life
    of me find filedata.c
    I'm using 1.1 ubuntu software centre standard install.
    Thanks in advance!


    [bugs:#190]http://sourceforge.net/p/geeqie/bugs/190 Find duplicates
    window update regression

    Status: open
    Group:
    Created: Wed Jan 30, 2013 09:54 PM UTC by Michael Schwendt
    Last Updated: Sun Nov 30, 2014 03:34 PM UTC
    Owner: nobody

    There is some regression in Geeqie 1.1 compared with 1.0:

    1.) open "File > Find duplicates ..." window
    2.) drag a folder, which contains a few test duplicate files, into the
    window
    3.) select one file of a pair of dupes
    4.) choose "Delete..." via right-click menu, or press Ctrl+D
    5.) in the "Delete files?" dialog, choose the "Delete" button

    What happens? The file gets deleted, but the "Find duplicates" window
    isn't updated. The file remains in the list of dupes. Similarly for the
    "Rename..." action. The new file name is not displayed automatically
    (only after rechecking manually via the "Compare by" box).

    In Geeqie 1.0, after deleting the file, the corresponding entry in the
    "Find duplicates" window disappears automatically.


    Sent from sourceforge.net because you indicated interest in
    https://sourceforge.net/p/geeqie/bugs/190/https://sourceforge.net/p/geeqie/bugs/190

    To unsubscribe from further messages, please visit
    https://sourceforge.net/auth/subscriptions/https://sourceforge.net/auth/subscriptions

    --
    PJ
    Android device kant speel with fat feengrrrs

     

    Related

    Bugs: #190

  • Simon Dedman

    Simon Dedman - 2015-04-07

    Ah. Duur. Cheers Paul.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks