From: Alex M. <al...@ca...> - 2010-05-13 07:50:08
|
Thanks David, your feedback is very much appreciated. I'm very short on time right now, but I'll take a look at the patch in a couple of weeks, unless someone does it earlier. Alex On Mon, May 10, 2010 at 6:42 PM, David Lobato <dav...@gm...> wrote: > Hi, > Building gearbox-9.11 I've seen that there are several checks for mayor and > minor version of cmake like this: > if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION EQUAL 6) > ... > else(...) > ... > endif(...) > It seems to me that in the if branch you want to use boost find scripts > included since version 2.6, and use a custom script otherwise. > At least in Ubuntu 10.04 cmake is at version 2.8, and I guess it has the > same or better boost scripts, but because of the "MINOR EQUAL 6" comparison, > in my system it's falling to the else branch. > I think it would be better to use: > if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION GREATER 5) > ... > else(...) > ... > endif(...) > I'm supposing that the checks in the if branch works for every version over > 2.5. > I've attached a patch to the trunk with the changes. > David. > ------------------------------------------------------------------------------ > > > _______________________________________________ > Gearbox-users mailing list > Gea...@li... > https://lists.sourceforge.net/lists/listinfo/gearbox-users > > |
From: Geoffrey B. <geo...@ai...> - 2010-05-13 08:08:09
|
Having just this minute finished something that's been keeping me busy for weeks, I can do it. Kitware certainly got to 2.8 faster than 2.6. I hope their rapid pace of development isn't going to cause issues. Geoff On 13/05/10 16:49, Alex Makarenko wrote: > Thanks David, > your feedback is very much appreciated. > I'm very short on time right now, but I'll take a look at the patch in > a couple of weeks, unless someone does it earlier. > > Alex > > > On Mon, May 10, 2010 at 6:42 PM, David Lobato <dav...@gm...> wrote: >> Hi, >> Building gearbox-9.11 I've seen that there are several checks for mayor and >> minor version of cmake like this: >> if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION EQUAL 6) >> ... >> else(...) >> ... >> endif(...) >> It seems to me that in the if branch you want to use boost find scripts >> included since version 2.6, and use a custom script otherwise. >> At least in Ubuntu 10.04 cmake is at version 2.8, and I guess it has the >> same or better boost scripts, but because of the "MINOR EQUAL 6" comparison, >> in my system it's falling to the else branch. >> I think it would be better to use: >> if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION GREATER 5) >> ... >> else(...) >> ... >> endif(...) >> I'm supposing that the checks in the if branch works for every version over >> 2.5. >> I've attached a patch to the trunk with the changes. >> David. |