Content-Type: multipart/alternative; boundary=001485e76dfe19c2a504863965e5

--001485e76dfe19c2a504863965e5
Content-Type: text/plain; charset=ISO-8859-1

Hi,

Building gearbox-9.11 I've seen that there are several checks for mayor and
minor version of cmake like this:

if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION EQUAL 6)
...
else(...)
...
endif(...)

It seems to me that in the *if* branch you want to use boost find scripts
included since version 2.6, and use a custom script otherwise.
At least in Ubuntu 10.04 cmake is at version 2.8, and I guess it has the
same or better boost scripts, but because of the "MINOR EQUAL 6" comparison,
in my system it's falling to the *else* branch.

I think it would be better to use:
if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION GREATER 5)
...
else(...)
...
endif(...)

I'm supposing that the checks in the if branch works for every version over
2.5.

I've attached a patch to the trunk with the changes.

David.

--001485e76dfe19c2a504863965e5
Content-Type: text/html; charset=ISO-8859-1

Hi,<div><br></div><div>Building gearbox-9.11 I&#39;ve seen that there are several checks for mayor and minor version of cmake like this:</div><div><br></div><div>if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION EQUAL 6)</div>
<div>...</div><div>else(...)</div><div>...</div><div>endif(...)</div><div><br></div><div>It seems to me that in the <i>if</i> branch you want to use boost find scripts included since version 2.6, and use a custom script otherwise.</div>
<div>At least in Ubuntu 10.04 cmake is at version 2.8, and I guess it has the same or better boost scripts, but because of the &quot;MINOR EQUAL 6&quot; comparison, in my system it&#39;s falling to the <i>else</i> branch.</div>
<div><br></div><div>I think it would be better to use:</div><div><div>if(CMAKE_MAYOR_VERSION EQUAL 2 AND CMAKE_MINOR_VERSION GREATER 5)</div><div>...</div><div>else(...)</div><div>...</div><div>endif(...)</div></div><div>
<br></div><div>I&#39;m supposing that the checks in the if branch works for every version over 2.5.</div><div><br></div><div>I&#39;ve attached a patch to the trunk with the changes.</div><div><br></div><div>David.</div>

--001485e76dfe19c2a504863965e5--