Menu
▾
▴
#20 Fix for closed bug ID: 3376330
This patch allows you to save application configuration when incorrect termination (power off / system crash / logout), save changes to documents and increases the line spacing in Scintilla. Working of Geany for me with this patch was much more convenient, but you check it out, if not more difficult. Thank you!
The Scintilla line spacing changes should be given to upstream Scintilla project (it has bug tracker here on SourceForge). It should be separate from the configuration saving stuff. But, why not use "SCI_SETEXTRAASCENT" through the proper API instead of adding in some magic number inside Scintilla code?
For configuration saving, why only save configuration on document "save as" instead of on open, or on settings change, or some other time? It seems kind of abitrary but I do still think the configuration should be saved more than just on correct closing.
Related:
https://github.com/geany/geany/pull/52
https://sourceforge.net/tracker/?func=detail&aid=3376330&group_id=153444&atid=787791
=> why not use "SCI_SETEXTRAASCENT"
=> through the proper API instead of adding in some magic number inside
=> Scintilla code?
I could not get a comfortable row spaces for GTK, so I just added pixels.
=> For configuration saving, why only save configuration on document "save as"
=> instead of on open, or on settings change, or some other time?
"Save as" a starting point and had to save the entire configuration together with the modified file. But the problem remained solved only partially. I think that is sufficient to address the underlying problem, save for the opening of new documents. But I still want to check out. But I came to the conclusion that it is better to save the configuration after the documents were opened. So would no longer be important, as will close the application.
Here's a view now has Scintilla
http://storage5.static.itmages.ru/i/12/1020/h_1350717605_5263018_09ddedca06.png
Unfortunately putting a fixed constant in Scintilla source imposes your preference on all those who don't want more spacing. We won't accept that.
Having a style setting in the colourscheme file is the proper way to do it. This should be applied through the normal Scintilla interface. The SCI_SETEXTRADESCENT call should be in pixels. If that interface doesn't work then that should be reported as a bug on Scintilla.
Also please only one change per patch, separating these two unconnected issues will make it easier to accept.
I cut out part of the patch, which increases row spaces and part sozraneniya on "Save as". A few minutes ago I built Geany with this new patch and it works for me as expected.