#686 Apply Button for Color Chooser

v1.23
closed-fixed
nobody
5
2014-03-07
2013-09-15
Bob Snyder
No

I am using Geany 1.23 and Linux (Slackware 13.37)

I have started doing some modest web development and have found the Color Chooser to be very useful for picking colors for various style properties. This is a great feature, but I have a suggestion to improve it: Add an "Apply" button to the Color Chooser dialog. Currently it has only "Cancel" and "OK." The effect would be the same as "OK" except that the dialog would remain open, just like with the Edit->Properties dialog.

Setting colors can be a very iterative process and the dialog has to be re-opened each time. This would allow one to tweak a color and observe the result in context without having to re-open the dialog each time.

Discussion

  • Peter Scholtens

    Peter Scholtens - 2013-09-16

    With a modification of only three lines I got the apply functionality added. Pressing "Apply" will now insert the choosen color without hiding the Color Chooser dialog everytime. To test, clone the git repo and replace the file in src/tools.c with the attachment. Maybe the following order "Cancel Apply OK" could be done different but I have no idea how to change that.

     
  • Bob Snyder

    Bob Snyder - 2013-09-16

    I have tested your file and it works perfectly! I agree about the order of buttons - "Apply Cancel Ok" would be consistent with the Preferences dialog. Many thanks.

     
  • Colomban Wendling

    • status: open --> closed-fixed
     
  • Colomban Wendling

    @peterscholtens Thanks for your work on an implementation, but please provide a unified diff file the next time, the problem with plain copies is that they are very hard to apply if any other change happened in the meantime. The very ideal solution is a Git-formatted patch ;)

     

Log in to post a comment.