#682 Request to update Scintilla component to take on KVIrc script lexer and folder

v1.23
open
nobody
None
5
2013-08-22
2013-08-22
No

Please could you update Scintilla so that the KVIrc Script lexer and folder I have successfully upstreamed is available.

This is based on a longterm project to extend geany so that I can develop KVIrc script in it as a first class language, like I used to develop mIRC script in mEditor under Windows (of course geany beats the latter hands down by default since its not proprietary ;))

Thanks

As instructed:

uname -a: Linux 3.9-1-amd64 #1 SMP Debian 3.9.8-1 x86_64 GNU/Linux

Discussion

  • Lex Trotman

    Lex Trotman - 2013-08-22

    Do you have the rest of the supporting data and code changes to add a KVirc filetype? Without that, a lexer is no use, so it wouldn't get added.

    See the HACKING file for how to add a filetype.

    A pull request on github is the preferred (and least likely to get lost) method for those changes.

     
  • Omega Weapon

    Omega Weapon - 2013-08-22

    I do - I was expecting first to get at geany + uptodate scintilla from clean geany upstream source, then move my current changes across and then make the request to upstream it officially into geany.

    Github pull request would be ideal.

     
  • Lex Trotman

    Lex Trotman - 2013-08-22

    If you make a pull request that includes all the changes to Geany required, it can include the Scintilla lexer so long as it is an exact copy of upstream, because it will get overwritten when a new version of scintilla is imported. In general only released versions of Scintilla are imported.

    Showing you have a full working Geany filetype gives greater confidence that it is suitable for inclusion. I don't know if Geany devs know this language, if they don't it will slow down inclusion since more effort is required to test it.

    If you can show that others have successfully used the github fork that you made the PR from, it would increase confidence and reduce the effort required, so possibly speeding up the inclusion process.

     
  • Omega Weapon

    Omega Weapon - 2013-08-22

    Yes, I already understand about scintilla - remember we talked in scintilla-interest and I have ensured that the lexer + folder was upstream before thinking about geany integration.

    OK, if you do use the exact scintilla source this is useful since I had the idea that geany changed it.

    It is already a full working filetype (all there in the github repo) as I have developed one script with it and maintain a number of others in it.

    I wasn't expecting the geany developers to do much more than 'it compiles, colours arent obviously broken and functions appear to be picked up', since the language is obscure - sounds like this will be a problem.

    Unfortunately there has been very little actual interest in the fork KVIrc-wise, so I dont have other known users (although there are 2 github 'stargazers' which I assume means they use the repo) - its fair enough that you want me to prove via someone else that it does the job. There is a bit of chicken and egg problem here, but I'll see what I can do.

     
  • Omega Weapon

    Omega Weapon - 2013-08-22

    I have just had a quick check of geany's scintilla and the canonical one from mercurial and geany does change the source! This is infact obvious as there is a changes patch file in the root directory!

    While personally I don't have a problem running patches, I'm going to keep this simple and repeat the request for an uptodate embedded scintilla that I can then work with. If you don't want to do this, I can wait for it to happen naturally.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks