#1075 Find dialog displayed outside visible screen range

[Charalampos Serenis]

This issue was discovered in 1.24.1 but I should affect previous/newer versions as well. The OS build is Windows 7. It can be reproduced only when the screen options have changed during the execution of geany. The Find dialog is shown on screen by the search_show_find_dialog() function. This function uses the previous position of the find dialog, providing it as argument to the set_dialog_position() function.(file src/search.c:563,572) There should be a validation that these screen coordinates still remain valid and if not they should be reset to 0,0.

Consider the following scenario/use case:
I have a laptop with a docking station and an external screen connected to the docking station. I open the find dialog and move it to the external screen since this is were I am working. Then close the find dialog and remove the laptop from the docking station. The external screen is not available any more. The coordinates stored in the find_dlg.position array are not valid any more since they correspond to a screen that does not exist any more. When I open the find dialog again it "opens" using this invalid coordinates that correspond to a position outside the visible range of the screen and I cannot see the dialog. The dialog has focus and can be operated (just not visible). The dialog can be moved to a visible position by hitting alt+space and selecting the move option.

A different use case might be the change in screen resolution (less resolution) but I have not reproduced.

[Colomban Wendling]

Duplicate of [bugs:#673].

There should be a validation that these screen coordinates still remain valid and if not they should be reset to 0,0.

Well, arguably Windows shouldn't allow placing windows outside the screen space, but well :) But yeah, we probably do need a fix for this anyway, we just have to find one and fix it.