Menu

#345 Reserved Python keyword used in function signature

2.4.5
closed
None
5
2015-02-25
2015-02-20
No

The variable name "as" in the function:

void gdcm::PresentationContext::SetAbstractSyntax(const char *as)

causing a syntax error in the Swig wrapper for Python because "as" is a reserved word in Python.

Discussion

  • Orion Poplawski

    Orion Poplawski - 2015-02-24

    Looks like we need something like:

    %rename(absyn) as;

    in gdcmswig.i

    But I'm not getting that to work. May need to actually rename it in the code.

     
  • Orion Poplawski

    Orion Poplawski - 2015-02-24

    Need to use:

    define as absyn

     
  • Mathieu Malaterre

    I used a less invasive patch. Please check. Thanks

    [release c333154] Do not use as since it is a reserved python keyword
    2 files changed, 2 insertions(+), 2 deletions(-)

     
  • Mathieu Malaterre

    • status: open --> closed
    • assigned_to: Mathieu Malaterre
     
  • Mathieu Malaterre

    • Group: 2.4.4 --> 2.4.5
     
  • Orion Poplawski

    Orion Poplawski - 2015-02-24

    Looks like you've missed gdcm-2.4.4/Source/MessageExchangeDefinition/gdcmPresentationContext.h

     
  • Mathieu Malaterre

    • status: closed --> open
     
  • Mathieu Malaterre

    • status: open --> closed
     
  • Mathieu Malaterre

    [release 31165f8] Another round of fixes for bug #345
    2 files changed, 2 insertions(+), 2 deletions(-)

     
  • Orion Poplawski

    Orion Poplawski - 2015-02-25

    That looks good now. Thanks!

     

Log in to post a comment.

MongoDB Logo MongoDB