Finally fixed today in both release+master branch. Thanks for your patience. Please use github next time !
Merge branch 'release'
Return None instead of empty buffer on jpeg error.
Add error handler for missing SOI
Here is a patch: --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,6 +23,9 @@ project(GDCM ## NOTE: the "DESCRIPTION" feature of project() was introduced in cmake 3.10.0 set(PROJECT_DESCRIPTION "GDCM - Grassroots DICOM. GDCM is yet another DICOM library.") +# https://sourceforge.net/p/gdcm/bugs/561/ +# due to https://gitlab.freedesktop.org/poppler/poppler/-/commit/d8ae3ba#9a2aa4db38d3115ed60da621e012c0efc0172aae +set(CMAKE_CXX_STANDARD 20) ## Set aliases for backwards compatibility. GDCM_VERSION_XXX...
Building with -DCMAKE_CXX_STANDARD=20 fixed it for me. That's due to poppler's change in https://gitlab.freedesktop.org/poppler/poppler/-/commit/d8ae3ba#9a2aa4db38d3115ed60da621e012c0efc0172aae
Maybe that is why the error says "FATAL FIPS SELFTEST FAILURE"?
Merge branch 'release'
Problem compiling with VTK 9.3.0 support
Problem compiling with VTK 9.3.0 support
GDCM does not use MD5 itself...only the test suite is using it.
GDCM crashes with a FIPS enabled machine
Please include(GNUInstallDirs) in CMakeLists.txt
Fixed de650849a1f294dda8401e2925c40daec51d0d3b thanks
Please include(GNUInstallDirs) in CMakeLists.txt
Fixed de650849a1f294dda8401e2925c40daec51d0d3b thanks
Fixed 3be6c2fa0945c91889bcf06e8c20e88f69692dd5 thanks !
Problem compiling with VTK 9.3.0 support
include(GNUInstallDirs) in CMakeLists.txt
Please include(GNUInstallDirs) in CMakeLists.txt
GDCM crashes with a FIPS enabled machine
Same here, gentoo updated to app-text/poppler-24.05.0 today.
Merge branch 'release'
Mark macOS CMake variables as advanced
do not set INSTALL_NAME_DIR for MacOS builds for CMake >= 3.0
3.0.24: build fails with poppler 24.05.0
Sorry, I don't have too much experience with c++ but I figured this would be a good chance to give it a shot. I added a handler for the JERR_NO_SOI which comes up when fragments are not grouped properly and a fragment with no SOI is passed into the JPEG code. I also modified the behavior of gdcm::JPEGCodec::Decode to return false instead of fail on the assertion when nfrags != this->GetNumberOfDimensions() And lastly I modified the python generating swig to return None instead of an empty buffer...
This closes https://sourceforge.net/p/gdcm/bugs/550/
Fix Not a JPEG error
Merge branch 'release'
Release 3.0.24
Allow --raw for DICOM/PDF
refactor code as function
Merge branch 'release'
COMP: Fix for gcc13.2 compiler test failures
Merge branch 'release'
Another pass for SIEMENS/MOSAIC
Merge branch 'release'
Another pass a fixing Siemens/MOSAIC IPP
Merge branch 'release'
Check for Secondary Capture spacing following DICOM Part 3 Sect A.8.1.3
Fix typos introduced in 4e328a6d54
Merge branch 'release'
Python 3.13: Replace deprecated PyEval_CallObject()
Merge branch 'release'
Mark COREFOUNDATION_LIBRARY as an advanced setting in cmake
VS 2022 shared build failure
encoding bug in OpenJPEG
Merge branch 'release'
Prefer CheckSymbolExists over CheckFunctionExists
Merge branch 'release'
Image Plane Module for SecondaryCaptureImageStorage
Merge branch 'release'
Ack that MFSPLIT/SIEMENS is using Modality LUT
Merge branch 'release'
Update to zlib 1.3.1
Merge branch 'release'
Handle more MFSPLIT case from SIEMENS
Merge branch 'release'
BUG: Fix GDCM crash when reading DICOM image
During conversion from implicit TS, GDCM sets VR of many (most) attributes VR::UN (unknown). I just tried converting from implicit TS and I can confirm this. Most likely, Horos was unable to cope with this at some point. CP-246
Hello @issakomi thanks for confirming this. I tried again with the "-U" option (described as "Use dict for VR (only public by default)") and now it opens correctly in all viewers including Horos. Cheers
During conversion from implicit TS, GDCM sets VR of many (most) attributes VR::UN (unknown). I just tried converting from implicit TS and I can confirm this. Most likely, Horos was unable to cope with this at some point.
Implicit VR DICOM image compressed to J2K with gdcmconv not rendering in Horos
large file extraction
Sorry I realized that JLSL_08_08_0_1F.dcm ought to work (per DCMTK). Here is what I see using gdcm from Debian/stable: % gdcmconv --raw /tmp/555/JLSL_08_08_0_1F.dcm gdcm.dcm % gdcminfo --md5sum gdcm.dcm MediaStorage is 1.2.840.10008.5.1.4.1.1.7 [Secondary Capture Image Storage] TransferSyntax is 1.2.840.10008.1.2.1 [Explicit VR Little Endian] NumberOfDimensions: 2 Dimensions: (128,128,1) SamplesPerPixel :1 BitsAllocated :8 BitsStored :8 HighBit :7 PixelRepresentation:0 ScalarType found :UINT8 PhotometricInterpretation:...
@scaramallion could you confirm what I see on my side: % for i in /tmp/555/*.dcm; do echo $i && dcmdjpls $i raw.dcm; done /tmp/555/JLSL_08_05_0_1F.dcm F: Codec received unsupported compression parameters: decompressing file: /tmp/555/JLSL_08_05_0_1F.dcm /tmp/555/JLSL_08_06_0_1F.dcm F: Invalid compressed image data: decompressing file: /tmp/555/JLSL_08_06_0_1F.dcm /tmp/555/JLSL_08_07_0_1F.dcm F: Invalid compressed image data: decompressing file: /tmp/555/JLSL_08_07_0_1F.dcm /tmp/555/JLSL_08_08_0_1F.dcm...
Issues decoding JPEG-LS pixel data
Remove symptoms from TALOS-2024-1944
Remove symptoms from TALOS-2024-1935
Remove symptoms of TALOS-2024-1924
./gdcmconv -i JLSL_08_07_0_1F.dcm -o out.dcm -w -V will work if GDCM is compiled with the newer CharLS (GDCM_USE_SYSTEM_CHARLS), as well as the other JLSL_08_ files. Found charls version 2.4.1 r@deb2:~/gdcm2/build/bin$ ./gdcmconv -i ~/Downloads/DICOM/bad_jpegls/JLSL_08_07_0_1F.dcm -o out.dcm -w -V r@deb2:~/gdcm2/build/bin$ JLSL_16_08_0_1F.dcm seems to have wrong DICOM BitsAllocated, why it is 16, JPEGLS says bitsPerSample = 8. so the issue, not sure. I didn't look at 'sign' issue, BTW.
Forgot to mention, this is all with the current master on github (3.1.0?). I've also seen the same behaviour in v3.0.23.
Issues decoding JPEG-LS pixel data
Add support for single SliceArray
Reduce error to warning level
Handle the famous inverted case
Refactor the API to not require GetImage()
Fix logic in SIEMENS/MOSAIC IPP computation
Expose Norm API
Make sure to re-normalize normal for proper computation
Merge branch 'release'
Default init variable
release 3.0.23
Merge branch 'release'
Release 3.0.23
Start using new API in gdcmclean tool